make default mods configurable #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in a backwards-compatible manner. Right now there are two options, either to enable a rather broad batch of modules that someone found to be a good default set, or to leave them unmanaged all-together. This patch provides the users wtih the ability to manage their set of default modules, by passing it as array to default_mods. This fixes #298 n.b.: we've added test cases here, but they aren't yet part of the actual test spec, because I have no idea how to do that.
hunner
added a commit
to hunner/puppetlabs-apache
that referenced
this pull request
Sep 4, 2013
PR puppetlabs#314 was merged without tests and consequently had bugs. This moves the `apache::default_mods::load` defined resource into `manifests/default_mods/load.pp` and adds the missing `mods` parameter to the `apache::default_mods` class. Also lots of tests are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in a backwards-compatible manner.
Right now there are two options, either to enable a rather broad batch
of modules that someone found to be a good default set, or to leave them
unmanaged all-together.
This patch provides the users wtih the ability to manage their set of
default modules, by passing it as array to default_mods.
This fixes #298
n.b.: we've added test cases here, but they aren't yet part of the
actual test spec, because I have no idea how to do that.