remove servername_real #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, if you did this:
apache::vhost { 'foo.example.com':
docroot => '/var/www/foo',
}
puppet would error, saying you need to specify servername and/or ip
and/or port.
but why?
just default to $name, as $servername_real was already sorta doing, but
it wasn't being fully utilized.
this commit gets rid of $servername_real and just makes $servername
default to $name if it's not specified, which is what I would expect it
to do anyways!
|
Thanks! This must be a historical artifact of code refactoring. |
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, if you did this:
apache::vhost { 'foo.example.com':
docroot => '/var/www/foo',
}
puppet would error, saying you need to specify servername and/or ip
and/or port.
but why?
just default to $name, as $servername_real was already sorta doing, but
it wasn't being fully utilized.
this commit gets rid of $servername_real and just makes $servername
default to $name if it's not specified, which is what I would expect it
to do anyways!