Fix parameters that take hash or array of hashes #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method used to cast scalars to arrays is `Array()`. This also will cast `nil` to an empty array, and preserve array depth for existing arrays. Casting hashes to arrays with `Array()` produces strange results and so the more verbose form of `[hsh].flatten.compact` must be used when a parameter may be one or more hashes. This updates the tests and templates accordingly.
apenney
pushed a commit
that referenced
this pull request
Aug 28, 2013
Fix parameters that take hash or array of hashes
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
* More idiomatic usage of parens for 'fail translate(('
* Change '((' to more idiomatic usage in install & service.pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method used to cast scalars to arrays is
Array(). This also willcast
nilto an empty array, and preserve array depth for existingarrays.
Casting hashes to arrays with
Array()produces strange results and sothe more verbose form of
[hsh].flatten.compactmust be used when aparameter may be one or more hashes. This updates the tests and
templates accordingly.