Remove default <proxy *> block #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| class apache::mod::proxy ( | |||
| $proxy_requests = 'Off', | |||
| $allow_from = ['127.0.0.1','::1'], | |||
| $allow_from = UNDEF, | |||
There was a problem hiding this comment.
Did you mean to have a lowercase undef? Is changing the default going to be backwards compatible?
There was a problem hiding this comment.
Yes, I probably meant undef, not UNDEF.
The idea with changing the default is to hand out more control: Now we can sensibly control access to reverse proxies too… Well.. on a server-wide-scale, but still.
|
Spec tests failed |
|
I'll need to rebase this against master and look again. Good thing about this: By now I know how to write tests. Please expect an update to this branch RSN. |
This is a horrible and generally useless default. Most people do *not* use apache httpd as Forward proxy, and those who do, should explicitly set an allow. That this is exactly what our new, and backward compatible proxy config does, and allows, while widly simplifying the reverse proxy configurations. We add a test case for new proxy configuration to make sure this is actually the case, and also fix a test case from a previious commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a horrible and generally useless default. Most people do not
use apache httpd as Forward proxy, and those who do, should explicitly
set an allow. That this is exactly what our new, and backward
compatible proxy config does, and allows, while widly simplifying the
reverse proxy configurations.
We add a test case for new proxy configuration to make sure this is
actually the case, and also fix a test case from a previious commit.