Fix invalid variable name in itk mod #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| service { 'httpd': | |||
| ensure => $service_enable, | |||
| name => $apache::apache_name, | |||
| name => $apache::params::apache_name, | |||
There was a problem hiding this comment.
I don't know that this is actually a bug. It might be better to have package_name and service_name parameters for the base class that default to $apache::params::apache_name and have the service/package resource reference those.
There was a problem hiding this comment.
hmmm, well currently its bug though because the param doesn't exist in init.pp right? It's weird that the tests still pass though.
There was a problem hiding this comment.
The root_group one above is a bug, but the apache_name is actually set in apache::params. Check out the package resource in init.pp.
|
@hunner updated. |
hunner
added a commit
that referenced
this pull request
Sep 24, 2013
Fix invalid variable name in itk mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.