mod_fastcgi #390
Merged
mod_fastcgi #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to the existing vhost modules the fastcgi module. Signed-off-by: Marc Koderer <m.koderer@telekom.de>
| apache::mod { 'fastcgi': } | ||
|
|
||
| if $fastcgi_lib_path { | ||
| file { 'fastcgi.conf': |
There was a problem hiding this comment.
Please add a template uses comment for the variables that its using. There are examples in the other mods.
| $itk = undef, | ||
| $fastcgi_server = undef, | ||
| $fastcgi_socket = undef, | ||
| $fastcgi_dir = undef, |
There was a problem hiding this comment.
Could you also document these three variables in the "template uses" comment above the vhost file resource? You can add a fastcgi fragment section right here https://github.com/jlambert121/jbartko-apache/blob/be3e87e88e0697370a6f08466b8b35f62509659d/manifests/vhost.pp#L366-L367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining #295 and #325 which are similar but not identical. Rebased on current master, merge conflicts resolved, attempted to address all of the comments/requests for changes.