Fix for https://github.com/puppetlabs/puppetlabs-apache/issues/248 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't pass the spec tests. Can you fix your commit message? The commit message should describe what the commit changes rather than a link to an issue.. |
|
The spec tests failed due to a github.com connection failure. Can you rerun them? Here is the output from that job: https://travis-ci.org/puppetlabs/puppetlabs-apache/jobs/12067336 I'm a git newbie - what is the best way to change the commit message? |
|
I could update the pull request message - is that sufficient? |
|
@glbsd |
…ison on line 20 now follows the style of the comparison on line 31.
|
@blkperl Done, thank you! |
|
Closes #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows the style of the comparison on line 31 to fix the reported bug.