Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for mod_proxy_ajp #398

Merged
merged 2 commits into from
Oct 4, 2013

Conversation

croddy
Copy link

@croddy croddy commented Oct 4, 2013

This adds basic support for mod_proxy_ajp so that it can be enabled in the same manner as other commonly-used Apache modules. mod_proxy_ajp is part of the base Apache module install on both Red Hat- and Debian-type systems so this should be all that is required.

@igalic
Copy link
Contributor

igalic commented Oct 4, 2013

👍 from me

But this wouldn't be me, if I didn't have any remarks: Note with newer versions of Tomcat at least we generally recommend the use HTTP as protocol. No need to add a translation layer in between.

Could you perhaps also add an rspec test? (to spec/defines/)

@trlinkin
Copy link
Contributor

trlinkin commented Oct 4, 2013

👍

@hunner
Copy link
Contributor

hunner commented Oct 4, 2013

@igalic I think rspec tests for this simple of a class without a config file, package, special library path, or parameters, getting by without a test is okay (since the only thing we could test is it { should contain_apache__mod('proxy_ajp') } and that's just implementation; rspec-puppet can't currently test resource relationships). Thanks for the feedback and comments! They're really helpful :).

hunner added a commit that referenced this pull request Oct 4, 2013
Add basic support for mod_proxy_ajp
@hunner hunner merged commit 279e696 into puppetlabs:master Oct 4, 2013
@croddy
Copy link
Author

croddy commented Oct 4, 2013

And I don't want to imply that I am endorsing designs based on mod_proxy_ajp... but that doesn't change the fact that there are still quite a few folks out there who need to puppetize existing Apache infrastructure that relies on this module.

traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants