Correct broken mime_magic config for Debian - Squashed commit for #418 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The location "conf/magic" in the mime_magic.conf template is RedHat specific and is broken under Debian/Ubuntu. Added a class parameter with an os agnostic default and matching template usage. Added full testing and updated `README.md` to indicated this module has settings and template parameters.
igalic
added a commit
that referenced
this pull request
Oct 26, 2013
Correct broken mime_magic config for Debian - Squashed commit for #418
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
The --mount parameter for Docker services is the equivalent to -v/--volume for standalone Docker containers. This patch allows to directly specify one or multile values for this argument directly as a Puppet parameter. This avoids the hassle of having to go through 'extra_params', since this is a commonly used option. https://docs.docker.com/storage/volumes/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've squashed my PR in #418 as requested.
Commit Message:
The location "conf/magic" in the mime_magic.conf template is RedHat specific
and is broken under Debian/Ubuntu. Added a class parameter with an os agnostic
default and matching template usage.
Added full testing and updated
README.mdto indicated this module hassettings and template parameters.