vhost directories fix #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.html#allowoverride "AllowOverride is valid only in <Directory> sections specified without regular expressions, not in <Location>, <DirectoryMatch> or <Files> sections."
| @@ -15,10 +15,12 @@ | |||
| <%- if directory['options'] -%> | |||
| Options <%= Array(directory['options']).join(' ') %> | |||
| <%- end -%> | |||
| <%- if directory['allow_override'] -%> | |||
| <%- if directory['provider'] == 'Directory' %> | |||
| <%- if directory['allow_override'] -%> | |||
| AllowOverride <%= Array(directory['allow_override']).join(' ') %> | |||
There was a problem hiding this comment.
now you're checking for directory, but you're not checking if the path-spec begins with ~
There was a problem hiding this comment.
I realized that. One step at a time. The patch I provided resolves my issue.
On Nov 4, 2013, at 11:37 PM, Igor Galić notifications@github.com wrote:
In templates/vhost/_directories.erb:
@@ -15,10 +15,12 @@
<%- if directory['options'] -%>
Options <%= Array(directory['options']).join(' ') %>
<%- end -%>
- <%- if directory['allow_override'] -%>
- <%- if directory['provider'] == 'Directory' %>
<%- if directory['allow_override'] -%>
now you're checking for directory, but you're not checking if the path-spec begins with ~—
Reply to this email directly or view it on GitHub.
igalic
added a commit
that referenced
this pull request
Nov 5, 2013
AllowOverride only allowed in Directory
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Apache docs http://httpd.apache.org/docs/current/mod/core.html#allowoverride
This was causing a warning when I started Apache.