Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $root_group parameter #435

Merged
merged 1 commit into from
Nov 6, 2013
Merged

Conversation

ptomulik
Copy link
Contributor

@ptomulik ptomulik commented Nov 4, 2013

On some OSes (FreeBSD, for example) the root group's name is other than 'root'. This PR introduces $root_group paramater to deal with such situation. The $root_group parameter is used by #342. This PR is created to split #342 into parts to make review process easier, see #342 (comment).

@igalic
Copy link
Contributor

igalic commented Nov 5, 2013

You're not adding any include apache::params to those classes, is this going to work cleanly ?

@ptomulik
Copy link
Contributor Author

ptomulik commented Nov 5, 2013

Some of these manifests require apache class to be present (mod.pp, vhost.pp) which derives from apache::params. Other manifests are MPM modules, which are (always?) included from apache, so apache::params should already be present. These MPMs already used variables from apache class (apache::mod_dir) without without demanding explicitly the apache class to be included so it should not be any problem to use variables from apache::params as well.

apenney pushed a commit that referenced this pull request Nov 6, 2013
@apenney apenney merged commit e0cbcdd into puppetlabs:master Nov 6, 2013
@ptomulik ptomulik deleted the root_group branch November 8, 2013 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants