Workaround for apxs-loaded modules #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some OSes (FreeBSD) apxs tool is used to put LoadModule directives into httpd.conf during apache package (and apache modules) insallation/reinstallation. The apxs expects some LoadModule directives to be already present in httpd.conf (they may be commented-out) in order to decide where to put its own directives. This PR puts fake LoadModule directive (commented out) to httpd.conf. The $apxs_workaround boolean parameter in apache class decides, whether to use this workaround or not. This is used on FreeBSD, where apxs is used by ports package provider (and perhaps all other). Without this, the apache installation/reinstallation/deinstallation as well as installation of additional modules would fail. This PR was created in order to split puppetlabs#342 into smaller parts to make review process easier, see puppetlabs#342 (comment)
|
This problem does not appear when the apache is installed for the first time, but would appear when the httpd.conf is already installed on the target OS and we change MPM, or install additional modules (at least on FreeBSD). |
apenney
pushed a commit
that referenced
this pull request
Nov 7, 2013
Workaround for apxs-loaded modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some OSes (FreeBSD) apxs tool is used to put LoadModule directives
into httpd.conf during apache package (and apache modules)
insallation/reinstallation. The apxs expects some LoadModule directives
to be already present in httpd.conf (they may be commented-out) in order
to decide where to put its own directives.
This PR puts fake LoadModule directive (commented out) to httpd.conf.
The $apxs_workaround boolean parameter in apache class decides, whether
to use this workaround or not. This is used on FreeBSD, where apxs is
used by ports package provider (and perhaps all other). Without this,
the apache installation/reinstallation/deinstallation as well as
installation of additional modules would fail.
This PR was created in order to split #342 into smaller parts to make
review process easier, see
#342 (comment)