Fix directory fragment not setting AllowOverride

[Aethylred]

need to use the provider variable not the provider key value from the directory hash for matches

[igalic]

At a rough estimate, I believe we've now changed that line back and forth about 450 times.

Perhaps it's time to stop and contemplate.

[Aethylred]

currently, the master does not set AllowOverride. The directory fragment was pretty rough when I first wrote it though...

[igalic]

can you add a test to catch this?

[Aethylred]

yes... I think I can figure that out... and get a start on #456

I see that #440 is reproducing this bug into new features too. I may attempt to overachieve.

[igalic]

Please do!

[Aethylred]

Excellent, managed to rebase the commits together and preserve the contribution from @anyone-can-test

...next rspec tests...

[Aethylred]

Done, but not fixing the tests for #456 as I'd hoped. There are tests defined to match file content, but are not being executed.

[anyone-can-test]

Thank for for merging my changes.
Anything that I should do? I'm a very beginner, GitHub.

[Aethylred]

@anyone-can-test it's up to the repository maintainers now. I pulled your changes from your github fork to maintain your attribution to them and then used git rebase to collapse them into a single commit. A bit more fuss than cut-paste, but your contribution is still yours :)

[igalic]

@Aethylred thank you for the extra bit of work. @anyone-can-test thank you for the contribution!