No implicit <Directory> entry for ScriptAlias path #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as soon as I get some feedback on #490 or someone merges it, we can merge this |
|
@antaflos this looks like it needs to be rebased now. Would you mind? |
Support for ScriptAlias currently implicitly and automatically creates <Directory> configuration directives for the path component in a given ScriptAlias directive. These are not useful or needed, according to the mod_alias documentation. Fixes issue puppetlabs#486. This change also indirectly relates to puppetlabs#487 because the implicitly created <Directory> entry for each ScriptAlias path also had `SSLOptions +StdEnvVars` set for that directory.
|
I rebased and force-pushed. |
igalic
added a commit
that referenced
this pull request
Nov 22, 2013
No implicit <Directory> entry for ScriptAlias path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for ScriptAlias currently implicitly and automatically creates
configuration directives for the path component in a given
ScriptAlias directive. These are not useful or needed, according to the
mod_alias documentation. Fixes issue #486.
This change also indirectly relates to #487 because the implicitly
created entry for each ScriptAlias path also had
SSLOptions +StdEnvVarsset for that directory.