make sure that directories are actually a Hash #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -393,6 +393,9 @@ | |||
|
|
|||
| ## Create a default directory list if none defined | |||
| if $directories { | |||
| unless (is_hash($directories) or (is_array($directories) and is_hash($directories[0]))) { | |||
There was a problem hiding this comment.
I think this line should be:
unless is_hash($directories) or (is_array($directories) and is_hash($directories[0])) {
to make the tests happy.
|
updated |
|
Travis tests are still broken. |
|
weird, it's only failing on 1.8.7.. on some versions thereof. |
this should fix #535 n.b.: older versions of puppet do not support unless btw: When you switch from unless to if, you must also switch from 'foo or bar' to '!foo and !bar', because, logic.
blkperl
added a commit
that referenced
this pull request
Jan 24, 2014
make sure that directories are actually a Hash
|
This actually isn't related to #535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix #535