Don't purge mods-available dir when separate enable dir is used

[domcleal]

Purging /etc/apache2/mods-available on Debian when there are separate available/enabled directories is poor behaviour, since this isn't active configuration. When purged, you lose track of which modules are available but that this module doesn't handle.

This patch disables the purge behaviour on the module config directory, but only when there is also a separate module enabled directory.

[igalic]

is this sort of something that you could cover by specifying your default_mods?
Oh, funny. I just realized I didn't document that you can actually specify an array of modules in that option.
I wonder how @apenney didn't notice this :O

[domcleal]

Yes, it's possible to enable a module via that or apache::mod, that's not an issue.

My concern was that the current behaviour deletes example configuration files supplied by the apache2 package on Debian. I'd run this module in the default config on Ubuntu 12.04, then found it deleted the contents of /etc/apache2/mods-available, so "a2enmod version" didn't work as the .load file had been deleted from mods-available.

Sure, I can add the version module in using the module and it will recreate the .load file, but since the mods-available directory contains non-active configuration files, I don't think the module needs to delete them, it's unnecessary.

[igalic]

+1 on that, you're absolutely right.

[igalic]

Would you mind adding a test to acceptance/spec_class.rb also?

[domcleal]

The acceptance test nodeset only seem to contain an EL6 node, so I don't think we could test it as-is. There's already some spec coverage, so I'm not sure it's worth the effort of me trying to set up beaker!

[igalic]

I'd disagree with that notion: https://github.com/puppetlabs/puppetlabs-apache/tree/master/spec/acceptance/nodesets you just need to change the default to test a different platform.

[domcleal]

I see, though I'm unable to run Beaker as it doesn't work with vagrant-libvirt at the moment (a rabbit hole I don't have time for now, sorry). Hopefully the rspec-puppet coverage will suffice.

[blkperl]

Restarted travis

[igalic]

Yeah, let's say it works for now, and we open an issue to add more tests.

[domcleal]

Thank you @igalic :)