Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache::mod::mime does not compile due to wrong file dependency #627

Merged
merged 2 commits into from
Mar 12, 2014
Merged

apache::mod::mime does not compile due to wrong file dependency #627

merged 2 commits into from
Mar 12, 2014

Conversation

carlossg
Copy link

Added specs

expected that the catalogue would include File[/etc/httpd/conf.d/mime.conf] used at modules/apache/manifests/mod/mime.pp:19 in Package[mailcap]

@igalic
Copy link
Contributor

igalic commented Feb 18, 2014

Hi @carlossg,
thank you very much for this contribution.
Do you think you could somehow add an spec/acceptance test for this (we really like to have those. A lot.)

@carlossg
Copy link
Author

there you have

@igalic
Copy link
Contributor

igalic commented Feb 24, 2014

Thanks, Alot. I'd like to have a second set of eyes (ping @apenney @blkperl @hunner ) before merging.

@carlossg
Copy link
Author

carlossg commented Mar 8, 2014

I've added another commit that fixes the same sort of error with the dependency to .load files

Fixes error "expected that the catalogue would include File[/etc/apache2/mods-available/proxy_html.load]"
Although the error should happen with other modules too

@carlossg
Copy link
Author

Fixing the compilation spec in FreeBSD, the regex had too many backslashes

@igalic
Copy link
Contributor

igalic commented Mar 10, 2014

Looking good now..
Would you very much mind squashing those commits to a more comprehensible assembly?

Carlos Sanchez added 2 commits March 11, 2014 09:48
Update rspec-puppet and add compilation specs to catch these errors
Add basic acceptance test for apache::mod::mime
Fix too many backslashes in FreeBSD regex for APACHE_PORT
Fixes error "expected that the catalogue would include File[/etc/apache2/mods-available/proxy_html.load]"
Add compilation specs
@carlossg
Copy link
Author

there you have

igalic added a commit that referenced this pull request Mar 12, 2014
apache::mod::mime does not compile due to wrong file dependency
@igalic igalic merged commit 513987d into puppetlabs:master Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants