Add rewrite_base functionality to rewrites #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously rewrite_base was a parameter to vhost, but was removed incorrectly. When rewrites was created to replace rewrite_* parameters, rewrite_base was forgotten. This adds back the deprecated rewrite_base parameter and adds the rewrite_base support to the rewrites parameter.
apenney
pushed a commit
that referenced
this pull request
Feb 19, 2014
Add rewrite_base functionality to rewrites
|
cough acceptance tests cough |
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
Fixing the fix 'Fix the docker_compose options parameter position puppetlabs#378'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously rewrite_base was a parameter to vhost, but was removed incorrectly. When rewrites was created to replace rewrite_* parameters, rewrite_base was forgotten. This adds back the deprecated rewrite_base parameter and adds the rewrite_base support to the rewrites parameter.
Closes #554