Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache version in Ubuntu 13.10 is 2.4 #672

Merged
merged 2 commits into from
Mar 10, 2014
Merged

Apache version in Ubuntu 13.10 is 2.4 #672

merged 2 commits into from
Mar 10, 2014

Conversation

carlossg
Copy link

Fix incorrect distrelease comparison

@scottasmith
Copy link
Contributor

This will not work.

Ubuntu only started on Apache in 13.10.

The distrelease variable only gets the 13 from 13.10.
Asking if distrelease >= 10 will stop all other Ubuntu boxes over 10.04 from working.

It was getting the version from $::operatingsystemrelease but has since been changed to be compared to an integer.

@scottasmith
Copy link
Contributor

Have a look at #669

@carlossg
Copy link
Author

yes, I had put the wrong number in there, should be distrelease >= 13, fixed now

@scottasmith
Copy link
Contributor

This will still not work. Ubuntu 13.04 uses Apache <2.4

Carlos Sanchez added 2 commits March 10, 2014 13:40
@carlossg
Copy link
Author

arg, ok, so now the fix is the same as #669 plus specs and fixed the Ubuntu/Debian acceptance spec, that was missing a module not included in defaults

@scottasmith
Copy link
Contributor

Awesome. I will close mine off.

This works with acceptance on the ubuntu-server-12042-x64 and ubuntu-server-1310-x64 nodesets?

@carlossg
Copy link
Author

yes, tested both ubuntus

@igalic
Copy link
Contributor

igalic commented Mar 10, 2014

rock on

igalic added a commit that referenced this pull request Mar 10, 2014
Apache version in Ubuntu 13.10 is 2.4
@igalic igalic merged commit 463b3d8 into puppetlabs:master Mar 10, 2014
@carlossg carlossg deleted the ubuntu-bad-version branch March 11, 2014 08:38
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
(MAINT) Use docker-compose config instead file parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants