Allow Apache service not to be managed by Puppet

[arnoudj]

Currently Apache can either configured to be 'running' or 'stopped'. In our cluster setup Apache is managed by Pacemaker, so Puppet should not interfere. Setting ensure to 'UNSET' will now set ensure to undef for the Apache service.

[igalic]

why not simply allow to pass service_enabled => undef ? Doesn't that solve the problem?

[arnoudj]

Nope, that will start the service again:

class { 'apache':
  service_enable       => false,
  service_ensure       => undef,
}
root@control3:~# puppet apply test.pp
notice: /Stage[main]/Apache::Service/Service[httpd]/ensure: ensure changed 'stopped' to 'running'
notice: Finished catalog run in 1.00 seconds

The apache class calls apache::service, which sets a default for service_ensure. So then I pass undef to apache, it gets set to 'running' by apache::service.

class apache::service (
  $service_name   = $::apache::params::service_name,
  $service_enable = true,
  $service_ensure = 'running',
)

[hunner]

@igalic Yeah, having a parameter passed => undef is like not passing the parameter at all, and will use the default value.

@arnoudj I think that pacemaker is a valid configuration (and I would like to get our corosync module up to snuff to work with all of our other modules!).

Could you code this so that running|stopped|true|false are all passed through, and any other value causes it to be undef? This will at least be backwards compatible. Could you also update the README, and add a beaker-rspec and/or rspec-puppet test? Thanks!

[arnoudj]

Done!

Would love to see the corosync module updated as well.