configure timeouts for apache::mod::reqtimeout #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,2 +1 @@ | |||
| RequestReadTimeout header=20-40,minrate=500 | |||
| RequestReadTimeout body=10,minrate=500 | |||
| RequestReadTimeout <%= @timeouts %> | |||
There was a problem hiding this comment.
I think it would make more sense to have timeouts be an array and then have something like:
<% Array(@timeouts).each do |timeout| -%>
RequestReadTimeout <%= timeout %>
<% end -%>
|
This is missing README updates and test coverage. |
|
@miiiche Fixed and rebased |
| } | ||
| ``` | ||
|
|
||
| **Parameters within `apache::mod::reqtimeout`:** |
There was a problem hiding this comment.
To keep with the format of the README, this line is unnecessary.
|
@roidelapluie Once you make the README updates could you squash this down to one commit? |
|
@mhaskel done :) |
underscorgan
pushed a commit
that referenced
this pull request
Aug 7, 2014
configure timeouts for apache::mod::reqtimeout
|
@roidelapluie thanks for the contribution! |
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Aug 15, 2022
Remove log_driver limitations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.