Call install_* methods only once in spec_helper_acceptance #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apenney @mhaskel I think that I've addressed the issue with hard coding versions! |
apenney
pushed a commit
that referenced
this pull request
Aug 11, 2014
…multiple-times Call install_* methods only once in spec_helper_acceptance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were calling
install_pe()orinstall_puppet()for each host even though that helper installs puppet across all hosts. This causes errors on multi host config setups. This also updates theinstall_puppet()invocation to install native packages on windows, osx and fall back to gem on other platforms.**note in local testing I got past the puppet installation (the affected code) but my run hung on the module install, so someone with a local setup should verify.