Finish SCL support for RHEL/CentOS 6 #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
|
Looks good to me. Can you squash the 3 commits into 1 commit too? |
|
I'll gladly squash it once the new tests pass. Does this look good now that the |
This is another change needed to make the httpd24 Software Collection work on RHELish boxes. Fix mod_systemd on RHEL/CentOS 6. Puppet < 3.0 does not have unless. Try another fix for Puppet 2.7 / Facter 1.7. Add README and tests for ::apache::conf_dir.
|
(Squashed; the tests are still passing.) |
underscorgan
pushed a commit
that referenced
this pull request
Aug 26, 2014
…-issues Finish SCL support for RHEL/CentOS 6
|
Looks good, thanks @smerrill! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit, along with #818 and #819, have allowed me to successfully use puppetlabs-apache to install and manage the httpd24 package from Software Collections on Red Hat 6.
I would like to let the current test suite pass, and then I know I owe a README update and some tests for the new
$::apache::conf_dirparameter.