Add support to set SSLCARevocationCheck on Apache 2.4 #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,7 @@ | |||
| $default_ssl_ca = undef, | |||
| $default_ssl_crl_path = undef, | |||
| $default_ssl_crl = undef, | |||
| $default_ssl_crl_check = undef, | |||
There was a problem hiding this comment.
Can you please align the '='?
|
In addition to my other comments, since this adds new parameters it will require README updates. |
domcleal
force-pushed
the
ssl-crl-check
branch
from
90fb800
to
309953a
Compare
Apache 2.4 needs an additional SSLCARevocationCheck directive to enable checking of a CRL, e.g. for a Puppet master vhost. See puppetlabs/puppet@b02af7e for more background
domcleal
force-pushed
the
ssl-crl-check
branch
from
309953a
to
acc7980
Compare
|
@mhaskel thanks for the review and test. Both items fixed, and the two parameters are now documented in the README. |
underscorgan
pushed a commit
that referenced
this pull request
Sep 29, 2014
Add support to set SSLCARevocationCheck on Apache 2.4
|
@domcleal thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache 2.4 needs an additional SSLCARevocationCheck directive to enable checking of a CRL, e.g. for a Puppet master vhost.
See puppetlabs/puppet@b02af7e for more background
The acceptance tests are provided untested - apologies, I don't have an environment to run them in.