MODULES-1696: ensure mod::setenvif is included if needed #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -390,6 +390,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| if ($setenv and ! empty($setenv)) or ($setenvif and ! empty($setenvif)) { | |||
There was a problem hiding this comment.
this seems redundant:
empty(undef) ==> true
empty([]) ==> true
empty('') ==> true
There was a problem hiding this comment.
This is just copying https://github.com/jlambert121/puppetlabs-apache/blob/modules_1696/manifests/vhost.pp#L393 - I think those two should match. The default for these is [], should it instead be undef? Otherwise this would by default always be true.
igalic
added a commit
that referenced
this pull request
Feb 6, 2015
MODULES-1696: ensure mod::setenvif is included if needed
|
thanks @jlambert121! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.