Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v9.2.0 #1150

Merged
merged 1 commit into from Dec 4, 2023
Merged

Release prep v9.2.0 #1150

merged 1 commit into from Dec 4, 2023

Conversation

github-actions[bot]
Copy link

Automated release-prep through pdk-templates from commit 146fe0b.
Please verify before merging:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


GitHub Actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

smortex
smortex previously approved these changes Nov 29, 2023
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these "other" PRs should be labelled "maintenance" to not appear in the changelog? I am fine with them, but I feel some effort was done in other repos to add a "maintenance" label on old PRs that where not adding features / fixing bugs, and maybe this repo slip through?

Maybe @Ramesh7 can tell us?

In any case, LGTM!

Copy link

@Ramesh7 Ramesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to label all PR first. Will look into this in some time.

@Ramesh7 Ramesh7 merged commit e0b3a5d into main Dec 4, 2023
1 check was pending
@Ramesh7 Ramesh7 deleted the release-prep branch December 4, 2023 03:45
@Ramesh7
Copy link

Ramesh7 commented Dec 4, 2023

I wonder if these "other" PRs should be labelled "maintenance" to not appear in the changelog? I am fine with them, but I feel some effort was done in other repos to add a "maintenance" label on old PRs that where not adding features / fixing bugs, and maybe this repo slip through?

Maybe @Ramesh7 can tell us?

In any case, LGTM!

Have updated all PRs which were missing with label and rerun the release prep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants