Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt::pin: handling all apt preferences properties #131

Merged
merged 3 commits into from
Jul 2, 2013

Conversation

mbornoz
Copy link

@mbornoz mbornoz commented Jun 18, 2013

The two forms of APT preferences records (general & specific) can now be
completely and not partially defined. All distribution properties can be passed
as resource parameters. This change is totally backward-compatible.

The two forms of APT preferences records (general & specific) can now be
completely and not partially defined. All distribution properties can be passed
as resource parameters. This change is totally backward-compatible.
@mbornoz
Copy link
Author

mbornoz commented Jun 18, 2013

IMHO it replaces the PR #130, @uu1101 what do you think?

Otherwise, I'm trying to fix tests with puppet 2.6

@mbornoz
Copy link
Author

mbornoz commented Jun 19, 2013

@puppetlabs have you ever had this kind of errors in Travis CI? https://travis-ci.org/puppetlabs/puppetlabs-apt/jobs/8226907

@uu1101
Copy link

uu1101 commented Jun 19, 2013

It covers my use-case (pinning by component), you can certainly close my pull request.

@hunner
Copy link

hunner commented Jun 25, 2013

@mbornoz Yeah I've had those errors. Since everything else is green I usually just ignore them since it's not a failure of the specs.

If you really want to re-trigger the travis build you could rebase the last commit with git commit --amend and just save the same commit message. This will cause the commit to have a new SHA-1 hash but the same contents, and you can force push it to your apt-preferences branch and travis will re-run the tests.

As for merging, puppetlabs-apt is on the schedule for reviewing all pull requests, but I'd like to merge bugfixes, release a version, and then merge features & release again. So this PR will get merged, but bugfix PRs will come first.

Thanks for your patience, and thanks so much for submitting a quality PR! :)

@mbornoz
Copy link
Author

mbornoz commented Jun 25, 2013

We @camptocamp decided to no longer maintain our own apt module. To be able to migrate to this "most popular" one, we depend on this change and hope that it'll be merge as soon as possible. If you notice that something isn't correct, don't hesitate to ping me.

Thank you in advance and don't worry, we are patient ;-)

@raphink
Copy link

raphink commented Jun 26, 2013

There's no need to do a git commit --amend as there's a button on the Travis interface to re-trigger a failed build without committing anything.

hunner added a commit that referenced this pull request Jul 2, 2013
apt::pin: handling all apt preferences properties
@hunner hunner merged commit c00888f into puppetlabs:master Jul 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants