-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apt::pin: handling all apt preferences properties #131
Conversation
The two forms of APT preferences records (general & specific) can now be completely and not partially defined. All distribution properties can be passed as resource parameters. This change is totally backward-compatible.
@puppetlabs have you ever had this kind of errors in Travis CI? https://travis-ci.org/puppetlabs/puppetlabs-apt/jobs/8226907 |
It covers my use-case (pinning by component), you can certainly close my pull request. |
@mbornoz Yeah I've had those errors. Since everything else is green I usually just ignore them since it's not a failure of the specs. If you really want to re-trigger the travis build you could rebase the last commit with As for merging, puppetlabs-apt is on the schedule for reviewing all pull requests, but I'd like to merge bugfixes, release a version, and then merge features & release again. So this PR will get merged, but bugfix PRs will come first. Thanks for your patience, and thanks so much for submitting a quality PR! :) |
We @camptocamp decided to no longer maintain our own apt module. To be able to migrate to this "most popular" one, we depend on this change and hope that it'll be merge as soon as possible. If you notice that something isn't correct, don't hesitate to ping me. Thank you in advance and don't worry, we are patient ;-) |
There's no need to do a |
apt::pin: handling all apt preferences properties
The two forms of APT preferences records (general & specific) can now be
completely and not partially defined. All distribution properties can be passed
as resource parameters. This change is totally backward-compatible.