Force owner and mode on ppa files

[daniellawrence]

This will make sure the generated files in ${sources_list_d} are a standard ownership and file mode.

I reached a problem with a module was forcing ownership of all files generated by the mode to be owned by the application that also include adding an apt::ppa resource.

eg.

File {
  mode => '0600',
  owner => 'applicationname',
  group => 'applicationname',
}
apt::ppa { 'ppa:extra-packages/ppa': }

Would cause the following permissions

ls -l /etc/apt/sources.list.d/extra-packages
-rw------- 1 applicationname applicationname  69 2014-02-04 10:46 extra-packages.list

Then the knock-on was apt-check was not able to read the new ppa configuration.

/usr/lib/update-notifier/apt-check
E: Error: Opening the cache (E:Opening /etc/apt/sources.list.d/extra-packages.list - ifstream::ifstream (13: Permission denied), E:The list of sources could not be read.)

[daenney]

This is good. @apenney @hunner, please?

[daenney]

@daniellawrence Could you perhaps add your changes to the ppa spec too so we ensure this behaviour doesn't occur again?

[daniellawrence]

@daenney -- I see what I can do about fixing up the ppa spec to stop regressions.

[hunner]

Arg. This is due to resource defaults being dynamically scoped still, which is a bug in puppet.

[uu1101]

Shouldn't the same be applied to https://github.com/puppetlabs/puppetlabs-apt/blob/master/manifests/ppa.pp#L61-64?