Adds check to params.pp if lab-release is not installed

[spuder]

Adds spec test

If lsb-release is not installed, then the end user sees a confusing/ vague message

Error: Unsupported lsbdistid () at /modules/apt/manifests/params.pp:52

It is common for docker containers to not include this package by default

After fix, the user sees a friendlier message if lab-release is not installed

Error: Unable to determine lsbdistid, is lsb-release installed? at /modules/apt/manifests/params.pp:52

[daenney]

Great, thank you for this. I've been battling to get lsb-release as a dependency for Facter in the Debian packages but no luck so far.

[spuder]

Instead of using lsbdist, I think it would be better to use $::osfamily and $::operatingsystem or $::operatingsystemrelease since they have been around since facter 1.6

http://serverfault.com/questions/478914/puppet-facts-should-we-use-lsbdistid-or-operatingsystem/479055#479055

http://jenkner.org/blog/2013/03/27/use-osfamily-instead-of-operatingsystem/

Because so many people depend on this module, I didn't want to make such a big rewrite.

[daenney]

That might not be a bad idea though people usually know Debian releases only by code name (Squeeze) or designation (old-stable), not by version (contrary to Ubuntu because Ubuntu has really crazy unpronounceable code names at times).

I'm gearing up for a serious rewrite of this module in preparation for Puppet 4 so I'll keep that in mind.

[underscorgan]

👍

Thanks for improving error messages @spuder!