Fix apt_has_updates fact not parsing apt-check output correctly #403
Conversation
WolverineFan
force-pushed
the
fix_apt_updates_facts
branch
from
07b3fe9
to
8c8a4b9
Compare
|
Added 2 additional tests to make sure the kind of error output that caused /dev/null to be added in the first place is handled gracefully. |
|
Sorry for the cross-pull talk. This seemed to be a fairly major problem because it is completely broken right now. Thanks for merging the other one, and I'll wait patiently for this one... |
WolverineFan
force-pushed
the
fix_apt_updates_facts
branch
from
8c8a4b9
to
cf7735f
Compare
|
@WolverineFan Thanks for submitting this. Could you please update the commit so that the unit tests will pass? Thanks. |
|
The test failures aren't due to this commit. The CI server is having problems (or it was anyway). I can upload it again to see if the CI server is functional again. |
|
Whoops! Apparently my last rebase was of the wrong branch! I'll fix that right now |
WolverineFan
force-pushed
the
fix_apt_updates_facts
branch
from
cf7735f
to
7ad7669
Compare
The /usr/lib/update-notifier/apt-check script returns its output to STDERR but a recent change to the script redirects STDERR to /dev/null. This will cause the array to always be empty. Combined with that problem, while we were checking for the result being nil, we never checked for an invalid array. As a result, the apt_has_updates was always true and the apt_updates and apt_security_updates facts were trying to read from an empty array and failing.
WolverineFan
force-pushed
the
fix_apt_updates_facts
branch
from
7ad7669
to
e7fee16
Compare
|
Looks like @cyberious found and fixed the problem in #410. I'm guessing it's a new version of Facter on the CI server returning different results. Anyway, I pulled in his test update (since it's more related to this patch than to his). All green now. |
|
Yeah I noticed that on Travis-CI it was using facter 1.7.6 but locally it was pulling down facter 2.x |
|
I'm gonna click the merge button, we can see what breaks next. @mhaskel We need to revisit these when we go for 2.0. |
Fix apt_has_updates fact not parsing apt-check output correctly
The /usr/lib/update-notifier/apt-check script returns its output
to STDERR but a recent change to the script redirects STDERR to
/dev/null. This will cause the array to always be empty.
Combined with that problem, while we were checking for the result
being nil, we never checked for an invalid array. As a result,
the apt_has_updates was always true and the apt_updates and
apt_security_updates facts were trying to read from an empty array
and failing.