Restore Puppet 3.4 and earlier compatibility #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,11 +27,11 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "pe", | |||
| "version_requirement": "3.x" | |||
| "version_requirement": ">= 3.3.0" | |||
There was a problem hiding this comment.
Why? If we support OSS 3.x we should be able to support PE 3.x too no?
There was a problem hiding this comment.
stdlib couldn't be upgraded to 4.x until PE 3.3
underscorgan
force-pushed
the
pup34_compat
branch
from
7f06597
to
229518f
Compare
|
This looks pretty awesome @mhaskel 💟. The only thing I worry a bit about now is that none of the tests cover the pre-3.5.0 behaviour. But that's going to be hard to do with unit tests and the strict vars mess since we're only faking the Puppet version. |
|
@daenney I did add one unit test to just make sure params didn't completely explode with puppetversion = 3.4.something. I ran acceptance tests manually with trusty and 3.4.3, and it passed now (and failed without the patch) |
|
Good enough for me. You have my 👍. |
bmjen
added a commit
that referenced
this pull request
Apr 27, 2015
Restore Puppet 3.4 and earlier compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.