Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-4686: gpg keyserver import fails in Debian 9 (Stretch) #698

Merged
merged 5 commits into from Sep 15, 2017

Conversation

deric
Copy link

@deric deric commented Sep 7, 2017

The command apt-key adv --list-keys on Debian 9 with argument --with-fingerprint prints the fingerprint for the subkeys too.

This patch fixes repeated apt keys imports during each Puppet run on Debian Stretch.

The patch comes from Alex P (alexpr) see discussion on Jira https://tickets.puppetlabs.com/browse/MODULES-4686

@deric deric changed the title Modules 4686: gpg keyserver import fails in Debian 9 (Stretch) MODULES-4686: gpg keyserver import fails in Debian 9 (Stretch) Sep 7, 2017
@hunner
Copy link

hunner commented Sep 13, 2017

Should the apt_key type autorequire the Package['dirmngr'] for these platforms as well?

* add Debian 9 as supported system
* move dirmngr ensure to init.pp
@deric
Copy link
Author

deric commented Sep 13, 2017

@hunner Yes, that's a good idea. Also define apt::setting isn't best location for ensuring package presence. I've also added Debian 9 as supported system.

@hunner hunner merged commit 1cc82ce into puppetlabs:master Sep 15, 2017
hunner added a commit that referenced this pull request Sep 15, 2017
MODULES-4686: gpg keyserver import fails in Debian 9 (Stretch)
@eLvErDe
Copy link

eLvErDe commented Sep 20, 2017

For the record:

I backported this patch for puppetlabs/apt 2.4.0 for people still running Puppet 3.

patch_puppet_apt_MODULES-4686_aka_keys_broken_on_stretch_from_upstream_c9800015fa342b9ceb7ef1a0eae27e9c481dcde8_backported_to_2.4.0.txt

It seems to be working fine.

Also if you had a dependency on apt::update like this:
Class['apt::update'] -> Package <| |>
Or
Class['apt::update'] -> Package <| title != 'apt-transport-https' |>

Modify it liks this:
Class['apt::update'] -> Package <| title != 'apt-transport-https' and title != 'dirmngr' |>

Adam.

@LukasAud LukasAud added the bugfix label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants