Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports.pp: correct example #962

Merged
merged 1 commit into from Dec 14, 2020
Merged

Conversation

kenyon
Copy link

@kenyon kenyon commented Dec 14, 2020

The example treated this like a defined type, but it's a class.

@kenyon kenyon requested a review from a team as a code owner December 14, 2020 03:57
@puppet-community-rangefinder
Copy link

apt::backports is a class

Breaking changes to this file WILL impact these 6 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 233 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

The example treated this like a defined type, but it's a class.
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #962 (a3b82bc) into main (edd2cbb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files           5        5           
  Lines         263      263           
=======================================
  Hits          190      190           
  Misses         73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7efac...a3b82bc. Read the comment docs.

@david22swan
Copy link
Member

@kenyon Thanks for the fix :)
Will merge it now

@david22swan david22swan merged commit 139702c into puppetlabs:main Dec 14, 2020
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Dec 20, 2020
It's a class, not a defined type.

I missed this in puppetlabs#962
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Dec 20, 2020
It's a class, not a defined type.

I missed this in puppetlabs#962
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Dec 20, 2020
It's a class, not a defined type.

I missed this in puppetlabs#962
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Jan 10, 2021
It's a class, not a defined type.

I missed this in puppetlabs#962
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Jan 10, 2021
It's a class, not a defined type.

I missed this in puppetlabs#962
kenyon added a commit to kenyon/puppetlabs-apt that referenced this pull request Jan 12, 2021
It's a class, not a defined type.

I missed this in puppetlabs#962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants