Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5722) Add frozen string magic comment #61

Merged
merged 2 commits into from Sep 15, 2023

Conversation

mhashizume
Copy link
Contributor

This PR comprises work from #60 as well as an update to the Rake task that validates commit summaries.

b4ldr and others added 2 commits September 14, 2023 15:49
puppetlabs-augeas_core and puppet-augeasproviders_core both provide the
augeas feature.  However the both have slightly different files (this
lacking the frozen strings magic comment.  This causes puppet to perform
a change on every puppet run.

This PR updates the feature in this repo to add the magic comment so
both files match.  More then happy to explore alternate fixes
This commit updates the commits Rake check to include commit summaries
that begin with the Puppet Agent (PA) Jira project and removes
references to a non-existent CONTRIBUTION.md.
@mhashizume mhashizume added the enhancement New feature or request label Sep 14, 2023
@mhashizume mhashizume requested a review from a team as a code owner September 14, 2023 22:51
@tvpartytonight tvpartytonight merged commit 6cebc08 into puppetlabs:main Sep 15, 2023
14 checks passed
@mhashizume mhashizume deleted the PA-5722/main/frozen-string branch September 15, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants