pdk convert #5
Merged
pdk convert #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before pushing this module to the forge, It's necessary to adapt it todays best practice standards. To do this, I've leveraged the
puppet pdk convertfunction of the PDK.Several files were added but only a few were modified:
----------Files modified----------
ipcrm-change_window/metadata.json
ipcrm-change_window/spec/spec_helper.rb
ipcrm-change_window/Gemfile
ipcrm-change_window/.gitignore
ipcrm-change_window/.rspec
ipcrm-change_window/Rakefile
Creating PR to merge to test branch of puppetlabs/ipcrm-change_window to allow for real world testing before merging into master and releasing to the forge.