(MODULES-3043) add acceptance and reference test for choco install #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require 'master_manipulator' | ||
| test_name 'MODULES-3043 - C97739 - Install Client on Virgin System' | ||
|
|
||
| chocolatey_pp = 'include chocolatey' |
There was a problem hiding this comment.
This could be a failure point. I don't think we want to have this. I'd much prefer we use our internal chocolatey.nupkg that we use for our internal build systems.
Other than that, this looks pretty good.
| chocolatey_download_url => 'file:///C:/chocolatey.nupkg', | ||
| use_7zip => false, | ||
| } | ||
| include chocolatey |
There was a problem hiding this comment.
Getting closer. I think you mean to remove this line (the lines above are basically the same).
ThoughtCrhyme
force-pushed
the
master
branch
2 times, most recently
from
4654921
to
d50646e
Compare
|
|
||
| url = get_latest_chocholatey_download_url | ||
|
|
||
|
|
ThoughtCrhyme
force-pushed
the
master
branch
2 times, most recently
from
f179019
to
fcf7b40
Compare
|
👍 |
Added reference and acceptance tests for installing the Chocolatey application via the Chocolatey Module.
|
👍 |
ThoughtCrhyme
pushed a commit
to ThoughtCrhyme/puppetlabs-chocolatey
that referenced
this pull request
Mar 20, 2017
…subcommand (QA-2149) Add config subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reference and acceptance tests for installing the Chocolatey application via the Chocolatey Module.
https://tickets.puppetlabs.com/browse/MODULES-3043