Set script's group to 0 if script owner is root #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When files on a puppetmaster are owned by a non-root user, concatfragments.sh gets installed on the nodes with a group owner matching the one of the master. This has no security implications since the file is mode 755, but does lead to possible ping-pong situations when switching between environments where the files on the master have different group ownership. Use '0' instead of 'root', since the root user's main group isn't always 'root' on some BSDs, but always '0'.
|
I'm seeing this problem now that I've updated my concat module to 1.2.0 - the group owner of |
|
👍 |
hunner
added a commit
that referenced
this pull request
Mar 16, 2015
Set script's group to 0 if script owner is root
|
👍 |
|
🏆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When files on a puppetmaster are owned by a non-root user,
concatfragments.sh gets installed on the nodes with a group
owner matching the one of the master.
This has no security implications since the file is mode 755,
but does lead to possible ping-pong situations when switching
between environments where the files on the master have
different group ownership.
Use '0' instead of 'root', since the root user's main group
isn't always 'root' on some BSDs, but always '0'.