(MAINT) Addressing wrong Rubocop TargetRubyVersion #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, during the Puppet 8 support work, TargetRubyVersion was set to 2.7 and a cop rule was addressed according to it. However, the correct ruby version is 2.6. This commit aims to address the previously wrongly set version along with an unnecesary change that breaks some compatibility with 2.6 systems.
concat_file is a typeBreaking changes to this file WILL impact these 1 modules (exact match):Breaking changes to this file MAY impact these 2 modules (near match):This module is declared in 169 of 580 indexed public
|
ekohl
approved these changes
May 4, 2023
jordanbreen28
approved these changes
May 5, 2023
|
Worth noting that 2.6 was the correct target version as that's the version compatible with Puppetserver 7's jruby. |
|
@bastelfreak Can we fix voxpupuli/voxpupuli-rubocop#16 now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, during the Puppet 8 support work, TargetRubyVersion was set to 2.7 and a cop rule was addressed according to it. However, the correct ruby version is 2.6.
This commit aims to address the previously wrongly set version along with an unnecesary change that breaks some compatibility with 2.6 systems.