Fix Duplicate Stack Matching #785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Duplicate Stack Matching where part of the stack name exists in another stack
|
|
chelnak
reviewed
May 4, 2022
| @@ -44,7 +44,7 @@ | |||
| $provider = 'powershell' | |||
| } else { | |||
| $exec_path = [ '/bin', '/usr/bin', ] | |||
| $check_stack = "${docker_command} ls | grep ${stack_name}" | |||
| $check_stack = "${docker_command} ls | grep '${stack_name} '" | |||
There was a problem hiding this comment.
There is a whitespace here after the stack name interpolation.. should it be:
Suggested change
| $check_stack = "${docker_command} ls | grep '${stack_name} '" | |
| $check_stack = "${docker_command} ls | grep '${stack_name}'" |
|
@RXM307 Could you rebase your PR and resolve the conflicts in stack.pp please? |
|
Closed as this will now be progressed in #836 Thank you for identifying this issue! |
LukasAud
added a commit
that referenced
this pull request
May 30, 2022
…tching (GH-785) Fix duplicate stack matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Duplicate Stack Matching where part of the stack name exists in another stack