Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker::registry fixes #97

Merged
merged 1 commit into from Jan 3, 2018
Merged

docker::registry fixes #97

merged 1 commit into from Jan 3, 2018

Conversation

shamil
Copy link
Contributor

@shamil shamil commented Jan 3, 2018 •
edited

I had issues with latest version of the module (1.0.4). Specifically in docker::registry definition

This PR fixes the following issues:

  1. fix wrong $pass_hash condition, 'Undef' considered String and not real undef
  2. $server param may be an URI and can contain slashes (e.g: https://index.docker.io/v1/), so strip them.

davejrt
davejrt approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@davejrt davejrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davejrt davejrt merged commit 8f16663 into puppetlabs:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davejrt davejrt davejrt approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shamil @davejrt @Ramesh7