Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet module install puppetlabs-firewall fails #228

Closed
hesco opened this issue Jul 25, 2013 · 16 comments
Closed

puppet module install puppetlabs-firewall fails #228

hesco opened this issue Jul 25, 2013 · 16 comments

Comments

@hesco
Copy link
Contributor

hesco commented Jul 25, 2013

git:~# grep module_repository /etc/puppet/puppet.conf
module_repository = http://forge.puppetlabs.com

git:~# puppet module install puppetlabs/firewall
Preparing to install into /etc/puppet/modules/production ...
Error: No such file or directory - /etc/puppet/modules/production/firewall/CONTRIBUTING.md
Error: Try 'puppet help module install' for usage

git:~# puppet module install puppetlabs-firewall
Preparing to install into /etc/puppet/modules/production ...
Error: No such file or directory - /etc/puppet/modules/production/firewall/CONTRIBUTING.md
Error: Try 'puppet help module install' for usage

@ifireball
Copy link

Failes on Fedora 17 on my end as well:

puppet module install puppetlabs/firewall

Notice: Preparing to install into /etc/puppet/modules ...
Notice: Downloading from https://forge.puppetlabs.com ...
Notice: Installing -- do not interrupt ...
Error: No such file or directory - /etc/puppet/modules/firewall/spec/fixtures/modules/firewall/manifests
Error: Try 'puppet help module install' for usage

It does seem some files are missing:

ls -l /etc/puppet/modules/firewall/

total 48
-rw-r--r--. 1 501 games 324 Jul 13 02:48 Gemfile
-rw-r--r--. 1 501 games 1805 Jul 13 02:48 Gemfile.lock
drwxrwxrwx. 4 501 games 4096 Jul 13 02:48 lib
-rw-r--r--. 1 501 games 937 Jul 13 02:48 LICENSE
-rw-r--r--. 1 501 games 19138 Jul 13 02:48 metadata.json
-rw-r--r--. 1 501 games 280 Jul 13 02:48 Modulefile
-rw-r--r--. 1 501 games 392 Jul 13 02:48 Rakefile
drwxr-xr-x. 5 501 games 4096 Aug 3 11:23 spec

The "manifests" directory seems to be missing.

@blalor
Copy link

blalor commented Aug 9, 2013

Having this problem as well.

@apenney
Copy link
Contributor

apenney commented Aug 9, 2013

Weird, what version of puppet are you guys using?

root@ubuntu-server-12042-x64-vbox4210:/# puppet module install puppetlabs-firewall
Notice: Preparing to install into /etc/puppet/modules ...
Notice: Downloading from https://forge.puppetlabs.com ...
Notice: Installing -- do not interrupt ...
/etc/puppet/modules
└── puppetlabs-firewall (v0.4.0)

I'm wondering if this is some weird bug specific to one version of puppet.

@ifireball
Copy link

I'm using Puppet 3.2.3 running on Ruby 1.9.3, Fedora 17.

@apenney
Copy link
Contributor

apenney commented Aug 9, 2013

We're going to repackage and release a 0.4.1. I think it's related to checked out spec stuff breaking the package, as it makes a symlink to itself. Hopefully a repackage will magically fix it!

@blalor
Copy link

blalor commented Aug 9, 2013

Thanks, @apenney. I'm seeing the problem with librarian-puppet-maestrodev 0.9.9.8. Oddly enough, after a failed librarian-puppet install, running it again doesn't give the error.

Puppetfile:

forge "http://forge.puppetlabs.com"

mod 'puppetlabs/firewall', '0.4.0'

Output:

# librarian-puppet install
Error: No such file or directory - /tmp/librarian/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/puppetlabs/firewall/version/9eac01120a372609e0afa3b236d9ed2d/firewall/spec/fixtures/modules/firewall/manifests
Error: Try 'puppet help module install' for usage
/usr/lib/ruby/1.8/pathname.rb:1055:in `unlink': Directory not empty - /tmp/librarian/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/puppetlabs/firewall/version/9eac01120a372609e0afa3b236d9ed2d (Errno::ENOTEMPTY)
    from /usr/lib/ruby/1.8/pathname.rb:1055:in `unlink'
    from /usr/lib/ruby/gems/1.8/gems/librarian-puppet-maestrodev-0.9.9.8/lib/librarian/puppet/source/forge.rb:104:in `cache_version_unpacked!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-puppet-maestrodev-0.9.9.8/lib/librarian/puppet/source/forge.rb:47:in `install_version!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-puppet-maestrodev-0.9.9.8/lib/librarian/puppet/source/forge.rb:245:in `install!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/manifest.rb:97:in `install!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/action/install.rb:49:in `install_manifests'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/action/install.rb:48:in `each'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/action/install.rb:48:in `install_manifests'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/action/install.rb:39:in `perform_installation'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/action/install.rb:12:in `run'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/cli.rb:165:in `install!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-puppet-maestrodev-0.9.9.8/lib/librarian/puppet/cli.rb:64:in `install'
    from /usr/lib/ruby/gems/1.8/gems/thor-0.18.1/lib/thor/command.rb:27:in `__send__'
    from /usr/lib/ruby/gems/1.8/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'
    from /usr/lib/ruby/gems/1.8/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'
    from /usr/lib/ruby/gems/1.8/gems/thor-0.18.1/lib/thor.rb:363:in `dispatch'
    from /usr/lib/ruby/gems/1.8/gems/thor-0.18.1/lib/thor/base.rb:439:in `start'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/cli.rb:26:in `bin!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/cli.rb:31:in `returning_status'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/cli.rb:26:in `bin!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/cli.rb:47:in `with_environment'
    from /usr/lib/ruby/gems/1.8/gems/librarian-0.1.0/lib/librarian/cli.rb:26:in `bin!'
    from /usr/lib/ruby/gems/1.8/gems/librarian-puppet-maestrodev-0.9.9.8/bin/librarian-puppet:7
    from /usr/bin/librarian-puppet:19:in `load'
    from /usr/bin/librarian-puppet:19

@hesco
Copy link
Contributor Author

hesco commented Aug 10, 2013

puppet --version

3.0.0-rc8

ruby --version

ruby 1.9.3p194 (2012-04-20 revision 35410) [i686-linux]

facter | grep rubyversion

rubyversion => 1.9.3

cat /etc/debian_version

6.0.6

-- Hugh Esco

On Fri, 09 Aug 2013 10:16:52 -0700
Barak Korren notifications@github.com wrote:

I'm using Puppet 3.2.3 running on Ruby 1.9.3, Fedora 17.


Reply to this email directly or view it on GitHub:
#228 (comment)

Hugh Esco
404-424-8701
YourMessageDelivered.com
Keeping Your Group in the Loop
No Matter How Large or How Small

@pecastro
Copy link

Same issue here.
a clone of the repo seems to work just fine though.
When can one expect version 0.4.1 to be on forge ?

@hackdna
Copy link

hackdna commented Aug 26, 2013

Same issue on Ubuntu Precise 32-bit when deploying both with librarian-puppet (mod 'puppetlabs/firewall') and manually (sudo puppet module install puppetlabs/firewall --modulepath=/vagrant/modules --force) on a Vagrant VM. Error message:

Error: No such file or directory - /vagrant/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/puppetlabs/firewall/version/9eac01120a372609e0afa3b236d9ed2d/firewall/spec/fixtures/modules/firewall/lib
Error: Try 'puppet help module install' for usage

Error doesn't occur on the second run and module is installed successfully. Puppet version 2.7.19.

@yrousseau
Copy link

Error still present for me with RHEL5.9 with a puppet 3.2.4
My error :
[root@servername ~]# puppet module install puppetlabs/puppetdb
Notice: Preparing to install into /etc/puppet/modules ...
Notice: Downloading from https://forge.puppetlabs.com ...
Notice: Installing -- do not interrupt ...
Error: No such file or directory - /etc/puppet/modules/firewall/spec/fixtures/modules/firewall/manifests
Error: Try 'puppet help module install' for usage

I checked the missing file, it is a link to an inexisting folder...

@frozenfoxx
Copy link

Error still present here on RHEL5 with Puppet 3.2.2.

[root@puppet modules]# puppet module --environment development install puppetlabs/firewall
Notice: Preparing to install into /etc/puppet/environments/development/modules ...
Notice: Downloading from https://forge.puppetlabs.com ...
Notice: Installing -- do not interrupt ...
Error: No such file or directory - /etc/puppet/environments/development/modules/firewall/spec/fixtures/modules/firewall/lib
Error: Try 'puppet help module install' for usage

@apenney
Copy link
Contributor

apenney commented Sep 10, 2013

We think this is FINALLY fixed in 0.4.2. Somewhere along the way some changes to puppet module install made it break if it unpacked the symlink before the destination folder was on disk. I've removed those symlinks and now things seem happier.

@frozenfoxx
Copy link

Totally fixed for me, works instantaneously and awesomely on RHEL5.

@blalor
Copy link

blalor commented Sep 11, 2013

@apenney I've run into this with several modules, and although the symlinks in the tarball are a problem, they're only a symptom. I'd say this is a bug in the puppet module tool, unfortunately.

@blalor
Copy link

blalor commented Sep 11, 2013

And I've found the existing issue: http://projects.puppetlabs.com/issues/17033

@hesco
Copy link
Contributor Author

hesco commented Oct 2, 2013

works here, on newly updated puppet version 3.3.0

git:/etc/puppet# puppet module install --force puppetlabs-firewall
Notice: Preparing to install into /etc/puppet/modules/production ...
Notice: Downloading from http://forge.puppetlabs.com ...
Notice: Installing -- do not interrupt ...
/etc/puppet/modules/production
└── puppetlabs-firewall (v0.4.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants