Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect AlmaLinux as RedHat #1007

Closed
wants to merge 1 commit into from
Closed

Conversation

oranenj
Copy link

@oranenj oranenj commented Aug 25, 2021

AlmaLinux seems to be missing from the list of RedHat distros.

Though to be honest, the case statement in linux.pp could probably just check for $osfamily == "RedHat" instead of listing all of the options

@oranenj oranenj requested a review from a team as a code owner August 25, 2021 07:36
@CLAassistant
Copy link

CLAassistant commented Aug 25, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@puppet-community-rangefinder
Copy link

firewall::linux is a class

that may have no external impact to Forge modules.

This module is declared in 108 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan
Copy link
Member

Closing as support for AlmaLinux has been added, i.e. #1020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants