Add support for IPv6 hop limiting #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcanevet this needs test. Try adding rules to conversion_hash.rb to test the parser now with your new additions. |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@kbarber I can't figure out how to limit unit tests to ip6tables provider only (as hop_limit is only relevant in IPv6). |
|
Can one of the admins verify this patch? |
|
@mcanevet someone posted a patch that contained a solution to testing in ipv6 only: https://github.com/puppetlabs/puppetlabs-firewall/pull/165/files its not merged in, but if you wanted to re-use that code that would be swell. Seems to work and passes tests etc. |
Adds tests for ipv6, too. ip6tables handles fragmentation differently. There's a special module and a couple of matchers which are all needed to implement a stateless firewall correctly. known_boolean handling with etc has been generified. The known_boolean functionality was partly tailored to the :socket feature.
On request by kbarber.
|
I'll close this in favour of #165. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.