(#171) Added ensure parameter to firewall class #172
Conversation
This change adds the ensure parameter to the firewall class so that the appropriate iptables service for the operating system can be stopped. The reason for this change is to extend the class so that it is not just limited to running the service. The change to the manifests still made all the rspec tests pass, so it should not introduce any regressions. More rspec tests were also added to exercise the new code paths introduced. This pull request fixes issue #171.
|
Can one of the admins verify this patch? |
|
ok to test |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/139/) |
|
Merged build finished. (Status: FAILURE, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/139/) |
|
Looks like a failure in the system tests, we need to drop a default hiera.yaml down. This isn't your code @cr3 - let me fix it for you and I'll get another test run going. |
|
Aah I get it now. The new hiera requirement was triggered due to the new usage of parameters in this patch. Okay - I can solve this in rspec-system-puppet I think, the patch itself should be able to stay the same. |
|
restest this please |
|
retest this please |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/140/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/140/) |
|
Thanks for merging so quickly. Any plans on releasing a new version on forge.puppetlabs.com? |
|
@cr3 if you can help me out with updating the changelog I'll be happy to tag and do the release part on my end. Example of a changelog and release patch is here: 97a63a8 ... note the changelog isn't really just a git log 0.2.1..HEAD, its a more human breakdown of the commits that went into a release with a nice blurb for features. Since this is a feature release it would be 0.3.0 I think. |
|
@kbarber I could certainly try to summarize the commits since 0.2.1 in a more human breakdown and submit a pull request for 0.3.0 tomorrow, Thursday. As for the blurb, I looked at your example changelog and it describes one main feature for the release. Would you like to see a particular feature described in the blurb for 0.3.0? |
This change adds the ensure parameter to the firewall class so that
the appropriate iptables service for the operating system can be
stopped. The reason for this change is to extend the class so that
it is not just limited to running the service.
The change to the manifests still made all the rspec tests pass,
so it should not introduce any regressions. More rspec tests were
also added to exercise the new code paths introduced.
This pull request fixes issue #171.