Fixing regressions for Amazon Linux since RH7 support was added #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlehner616
changed the title
|
From looking at the code, this issue could be affecting other distributions as well. |
|
@puppetcla to save time and get this thing merged, CLA has been signed. |
|
@mlehner616 Can you squash this down to a single commit? Otherwise looks good, and just FYI the CLA isn't required for module contributions |
|
@mhaskel Not a problem, I'll squash it. ok, figured I'd get it signed just in case, I saw it was holding up another PR (could have been another repo) |
Red Hat 7 has diverged from the Amazon system architecture and Amazon uses a different versioning scheme. It's possible Amazon may re-align with Red Hat 7 in later releases. Additional logic may be required when that happens. Description: Adding an exception for Amazon as the conditions for RH7 were incorrectly catching Amazon because the version YYYY.MM will always evaluate to true
|
@mhaskel Should be all set just waiting to hear from Travis |
underscorgan
pushed a commit
that referenced
this pull request
Jan 22, 2015
Fixing regressions for Amazon Linux since RH7 support was added
|
Great, thanks @mlehner616 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
Fixing regressions for Amazon Linux since RH7 support was added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding support for RH7, Amazon was getting incorrectly grouped with those newer operating systems. Amazon Linux is still using the RH6 way to do things making the module unusable on all Amazon systems. I'm adding exceptions for Amazon as the conditions for RH7 were incorrectly catching Amazon Linux because the operatingsystemrelease YYYY.MM will always evaluate to
true