Uid negation fix #474
Merged
Uid negation fix #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the uid feature of the firewall module, it did not work with string based usernames as documented. The uid propery always synchronized with a message of <number> does not match <username>. This code overrides the uid getter method to perform a check of both the data from the property hash as well as using that data (assuming it is a uid) to resolve the username. While this patch is pretty simple, I have only tested it on Ubuntu 14.04. I am not sure if it could be problematic with other versions. I have not yet written tests b/c I wanted to submit my proposed fix for discussion while I get those written.
Re-applying a manifest with an unchanged UID will now not re-apply the rule unnecessarily.
|
@bodepd thoughts? You cool with us closing yours and merging this with yours as well? |
|
Fixes #466 |
|
no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for MODULES-1688.
Re-applying a manifest with an unchanged UID will now not re-apply the rule unnecessarily. Works properly for negated and non-negated cases.