MODULES-1619 Add haproxy version fact #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added new logic around the which parameter for checking haproxy present before running the fact
|
Supersedes #140 |
Otherwise it fails with:
```
Mocha::ExpectationError:
unexpected invocation: Facter::Util::Resolution.which('uname')
```
cmurphy
added a commit
that referenced
this pull request
Jan 8, 2015
…fact MODULES-1619 Add haproxy version fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some haproxy config settings and features that are version dependant, so it'd be cool if we could find out what version of Haproxy is running before adding them etc.