Made chroot optional #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just about to make this PR myself, but you beat me to it. +1 from me. |
|
Heh, just did this myself. +1 here too. |
|
This works quite well. I'm also in favor of this being merged. |
|
Thanks for testing this PR out! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-haproxy
that referenced
this pull request
Dec 19, 2017
Made chroot optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If chroot was left unspecified, the module would crash with a
File[undef]error. There are no tests yet, but they can be added. I only needed to start logging, and removing the chroot was the quickest way for me to go forward. Enabling UDP is the real solution, which I'll later.If making chroot optional is useless, I'll just use this until I've enabled UDP syslog, then remove this branch.