Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mange_config_dir parameter #286

Closed
wants to merge 1 commit into from

Conversation

posteingang
Copy link

make $haproxy::manage_config_dir useable in config.pp

make $haproxy::manage_config_dir useable in config.pp
@pmcmaw
Copy link

pmcmaw commented Nov 14, 2017

Hey @posteingang currently this change results in test failures.
If you could address this I will work on getting your change merged.

@hunner
Copy link

hunner commented Jan 16, 2018

The base class is just a thin wrapper around a default declaration of haproxy::instance which is where the real interface is. The way to make this change would be to add a manage_config_dir parameter to haproxy::instance and then also pass that through to the haproxy::config resource declared by haproxy::instance. That's why the tests are failing.

@david22swan
Copy link
Member

@posteingang Is there any movement on this PR?

@posteingang
Copy link
Author

@david22swan Sry, for the late response. At the moment I have not enough time to fix the tests. Unfortunately I am not a create dev so maybe someone else can help?

@david22swan
Copy link
Member

@posteingang Apologies but I am unsure if there any any within the team that have the time to work on this as we have been rather busy over the last few months. If you yourself do not have the time to finish this then it may be best to open up a ticket detailing what you have done, and had planned to do and submit it to be appraised. If it is accepted it will then be put on our backlog of work to be completed at a later time.

@david22swan
Copy link
Member

@posteingang Apologies but due to the length of time that this has lain fallow without anyone taking it up I am know closing this PR. I apologize, and if in the future you choose to submit once again, we will happily review it.
Best Wishes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants