Ensure multiple instances may be created with the default package.

[surprisingb]

In a scenario with multiple instances, the services' files won't be created if the default haproxy package is used.
The title itself MUST be different between the instances, but the package could be the same for all of them.

[lionce]

Hello @surprisingb ,

Thank you for your contribution, but it looks like the unit tests are failing. In order to merge your PR, please fix the errors. Please let us know if you need any help.

[surprisingb]

Hi @lionce,
I've looked at the code but I'm not really sure about this.
The error thrown on the unit tests are like this:

1) haproxy::instance_service when on any platform with title group1 and custom settings installs the customhaproxy package
     Failure/Error: content => template($haproxy_unit_template),

     Puppet::PreformattedError:
       Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Could not find template '' (file: /home/travis/build/puppetlabs/puppetlabs-haproxy/spec/fixtures/modules/haproxy/manifests/instance_service.pp, line: 107, column: 20) (line: 2) on node travis-job-2538e14a-d52e-4ac6-9729-124276d3de8b.c.eco-emissary-99515.internal

but the $haproxy_unit_template parameter is undef by default, and I didn't change anything related to this.

[lionce]

Hey @surprisingb ,

I'll have a look on this!

Cheers!

[carabasdaniel]

Hi @surprisingb,

Could you please rebase this to the latest changes on master ?

Thank you.

[surprisingb]

I rebased my repo but the error it's still the same.

[carabasdaniel]

Hi @surprisingb,

After looking through the failing test, apparently this change forces the haproxy_unit_template parameter (https://github.com/puppetlabs/puppetlabs-haproxy/blob/master/manifests/instance_service.pp#L42) to become required at https://github.com/puppetlabs/puppetlabs-haproxy/blob/master/manifests/instance_service.pp#L112.

So to get this working as it should could you try, as a first step, setting the haproxy_unit_template.

I hope this gives you a clear track on getting the tests passing.

Please feel free to reach out if you have difficulties with this.

Thanks.

[surprisingb]

Hi @carabasdaniel, I defined a default service unit template, I'm still getting an error:

1) haproxy::instance_service when on any platform with title group1 and custom settings installs the customhaproxy package
     Failure/Error:
       subject.should contain_package('customhaproxy').with(
         'ensure' => 'present',
       )
     
     Puppet::Error:
       Could not find resource 'Service[haproxy-haproxy]' in parameter 'before' (file: /home/travis/build/puppetlabs/puppetlabs-haproxy/spec/fixtures/modules/haproxy/manifests/instance_service.pp, line: 120) on node travis-job-abfb9ec9-3745-4ec5-9880-c406d71f2401.c.eco-emissary-99515.internal

Line 120 refers to before => Service["haproxy-${title}"],, but the title should be group1, why is it looking for Service[haproxy-haproxy]?

I also just found this note that I didn't see before, and maybe this specific use case is what the note is referring to... What do you think?

[lionce]

Hello @surprisingb , in order to fix the tests (Could not find resource 'Service[haproxy-haproxy]' in parameter 'before'), you should add a pre_condition block with service {'haproxy-#{title}': }

let(:pre_condition) do
      <<-PUPPETCODE
        service {'haproxy-#{title}': }
      PUPPETCODE
    end

The error is pointing to haproxy because title is still haproxy - check this line .
You also should update the paths when title is different than haproxy e.g. this line
I hope this helps you on getting the tests passing!
If you need any help, feel free to contact us. :)

Cheers!

[lionce]

Hello @surprisingb ,

Please let us know if you're still working on this PR! If you need any help don't hesitate to ask. Thanks!

Cheers!

[lionce]

Hello @surprisingb ,

i've updated your branch to include latest updates from master and fixed the failing tests.

Cheers!

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@0ec0a02). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #348   +/-   ##
=========================================
  Coverage          ?   16.66%           
=========================================
  Files             ?        1           
  Lines             ?        6           
  Branches          ?        0           
=========================================
  Hits              ?        1           
  Misses            ?        5           
  Partials          ?        0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec0a02...7fa7946. Read the comment docs.